fix(doctor): probe real provider binary (claude/codex), not the provider key - #24
Open
dk96-creator wants to merge 1 commit into
Open
fix(doctor): probe real provider binary (claude/codex), not the provider key#24dk96-creator wants to merge 1 commit into
dk96-creator wants to merge 1 commit into
Conversation
…der key `mirofish doctor` checked shutil.which(LLM_PROVIDER) — i.e. it looked for a binary literally named "claude-cli"/"codex-cli". Those binaries don't exist; the LLM client (app/utils/llm_client.py) shells out to "claude"/"codex". So doctor reported `[FAIL] claude-cli binary on PATH` even on a correctly configured machine where the tool runs fine. Map the provider key to its real binary name before the PATH probe. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
mirofish doctorreports[FAIL] claude-cli binary on PATHon machines where MiroFish actually runs fine.The check in
app/cli.pycallsshutil.which(Config.LLM_PROVIDER), butLLM_PROVIDERis the provider key (claude-cli/codex-cli), not a binary name. No binary namedclaude-cliexists —app/utils/llm_client.pyshells out toclaudeandcodex. Sodoctorfails even though the real LLM call path resolves the binary correctly.Fix
Translate the provider key to its real binary name (
claude-cli→claude,codex-cli→codex) before theshutil.whichprobe, and label the check row with the resolved binary name.Verification
With
claudev2.x on PATH:[FAIL] claude-cli binary on PATH[PASS] claude binary on PATH→doctor: all checks passed, exit 0🤖 Generated with Claude Code